chore: update errors to be stringified when object #32663
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
stringify-studio-errors
|
| Run status |
|
| Run duration | 16m 29s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
1
|
Pending
|
11
|
Skipped
|
0
|
Passing
|
631
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
0%
|
|
|---|---|
|
Untested elements
|
4
|
|
Tested elements
|
0
|
Accessibility
100%
|
|
|---|---|
|
Failed rules
|
0 critical
0 serious
0 moderate
0 minor
|
|
Failed elements
|
0
|
Tests for review
cypress/e2e/studio/studio.cy.ts • 1 failed test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress Studio > updates an existing test with assertions |
Test Replay
Screenshots
|
|
cypress/e2e/cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| * Safely serializes an error object to a string, handling circular references | ||
| * and other non-serializable values that would cause JSON.stringify to throw. | ||
| */ | ||
| export function safeErrorSerialize (error: unknown): string { |
There was a problem hiding this comment.
I wonder if we should just use the structured clone algorithm.
There was a problem hiding this comment.
yah this is why I didn't want to get deep into this 😅
Before I looked at using https://www.npmjs.com/package/serialize-error
There was a problem hiding this comment.
This should be addressed now
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Additional details
We're getting some errors in Sentry that are reporting [object Object] and I'd like to be able to actually see the errors. Example error.
This solution isn't foolproof - it's expecting a string or object, but I just want a quick solution. I went down a rabbithole of consolidating all the error serialization one day and it was too much.
Steps to test
How has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?Note
Safely serialize non-Error exceptions using serialize-error and propagate this in Studio error handling/reporting, with new tests and dependency.
exception.safeErrorSerializeinpackages/server/lib/cloud/exception.tsusingserialize-errorto robustly stringify unknown errors (handles circular refs, primitives, undefined/null).Errorvalues toErrorin:packages/server/lib/cloud/api/studio/report_studio_error.tspackages/server/lib/cloud/studio/studio.ts(sync and async invocations)safeErrorSerializeinpackages/server/test/unit/cloud/exceptions_spec.js.Errorhandling in both sync/async paths and API reporting.serialize-errortopackages/server/package.json.Written by Cursor Bugbot for commit 0be6bef. This will update automatically on new commits. Configure here.