Skip to content

Conversation

cacieprins
Copy link
Contributor

@cacieprins cacieprins commented Oct 8, 2025

Additional details

Most notably in CT, when running Cypress in development mode, the STDERR marking tokens were appearing in the final cli output. This:

  • Ensures that we are not adding tokens when we shouldn't (e.g., debugging electron, internal development mode for Cypress)
  • Ensures that we are not stripping tokens when we aren't adding them
  • Refactors to make this distinction easier to determine

Steps to test

Check out and build; run cypress:run --component --project ./packages/driver, ensure no tokens exist in the output

How has the user experience changed?

PR Tasks


Note

Disable stderr tag injection in development or with ELECTRON_ENABLE_LOGGING=1, refactor filtering/TagStream to use tagsDisabled(), update tests, and add changelog entry.

  • stderr filtering:
    • Tagging control: Introduce tagsDisabled() to disable tags when CYPRESS_INTERNAL_ENV=development or ELECTRON_ENABLE_LOGGING=1.
    • Refactor Filter: Remove disableTags param; decide tagging via tagsDisabled() and only create FilterTaggedContent when enabled.
    • Refactor TagStream: Add conditional tag() method, output Buffer.from('') for empty chunks, and add verbose debug namespace.
    • logError: Use tagsDisabled() to bypass tags; minor comment cleanup.
    • Tests: Update/spec new cases to cover tag disabling, buffering behavior, and environment stubbing; use vi.stubEnv/vi.unstubAllEnvs.
  • Changelog:
    • Add 15.4.1 bugfix note describing reduced verbose stderr tagging in development/Electron logging modes.

Written by Cursor Bugbot for commit 5af007d. This will update automatically on new commits. Configure here.

@cacieprins cacieprins changed the title Fix: stderr tokens are no longer injected when in development mode fix: stderr tokens are no longer injected when in development mode Oct 8, 2025
@cacieprins cacieprins marked this pull request as ready for review October 8, 2025 13:51
@cacieprins cacieprins requested a review from AtofStryker October 8, 2025 13:52
cursor[bot]

This comment was marked as outdated.

Copy link

cypress bot commented Oct 8, 2025

cypress    Run #66316

Run Properties:  status check failed Failed #66316  •  git commit 5af007d18a: Merge branch 'develop' into fix/stderr-tokens-dev-mode
Project cypress
Branch Review fix/stderr-tokens-dev-mode
Run status status check failed Failed #66316
Run duration 21m 03s
Commit git commit 5af007d18a: Merge branch 'develop' into fix/stderr-tokens-dev-mode
Committer Cacie Prins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 15
Tests that did not run due to a developer annotating a test with .skip  Pending 1102
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26706
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.27%
  Untested elements 186  
  Tested elements 158  
Accessibility  97.97%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

Tests for review

Failed  cypress/e2e/studio/studio.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
Cypress Studio > updates an existing test with assertions Test Replay Screenshots
Flakiness  commands/files.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > throws when there is an error reading the file Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome:beta

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay

The first 5 flaky specs are shown, see all 13 specs in Cypress Cloud.

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack info logs less readable with CYPRESS.STDERR annotations
2 participants