Skip to content

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Oct 8, 2025

  • Closes

Additional details

converts @packages/v8-snapshot-require tests from mocha to vitest. Conversion is 1:1

Steps to test

How has the user experience changed?

PR Tasks


Note

Migrates @packages/v8-snapshot-require tests to Vitest, updates configs/deps and assertions, adjusts CI expected test results, and marks guide status complete.

  • Binary Packages:
    • @packages/v8-snapshot-require:
      • Replace Mocha/Chai with Vitest: update test assertions and imports in test/*.spec.ts.
      • Add vitest.config.ts; remove test/.mocharc.js.
      • Update package.json scripts (test-unit -> vitest run, add test-debug) and devDeps (remove mocha, add vitest).
  • CI:
    • .circleci/src/pipeline/@pipeline.yml: lower sanitize-verify-and-store-mocha-results.expectedResultCount in unit-tests from 10 to 9.
  • Docs:
    • guides/esm-migration.md: mark packages/v8-snapshot-require as completed.

Written by Cursor Bugbot for commit 5d84ef9. This will update automatically on new commits. Configure here.

@AtofStryker AtofStryker self-assigned this Oct 8, 2025
Copy link

cypress bot commented Oct 8, 2025

cypress    Run #66314

Run Properties:  status check failed Failed #66314  •  git commit 5d84ef94fa: chore: convert v8-snapshot-require tests to vitest
Project cypress
Branch Review chore/convert_v8_snapshot_require_vitest
Run status status check failed Failed #66314
Run duration 46m 08s
Commit git commit 5d84ef94fa: chore: convert v8-snapshot-require tests to vitest
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 13
Tests that did not run due to a developer annotating a test with .skip  Pending 1102
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26577
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.4%
  Untested elements 185  
  Tested elements 158  
Accessibility  97.97%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

Tests for review

Failed  cypress/e2e/studio/studio.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
Cypress Studio > updates an existing test with assertions Test Replay Screenshots
Flakiness  commands/waiting.cy.js • 2 flaky tests • 5x-driver-chrome

View Output

Test Artifacts
... > errors > throws when route is never resolved Test Replay
... > errors > throws when waiting for 2nd response to route Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-inject-document-domain-chrome

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay

The first 5 flaky specs are shown, see all 11 specs in Cypress Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant