Skip to content

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Oct 8, 2025

  • Closes

Additional details

converts @packages/v8-snapshot-require tests from mocha to vitest. Conversion is 1:1

Steps to test

How has the user experience changed?

PR Tasks


Note

Migrates @packages/v8-snapshot-require tests to Vitest, adds vitest config, updates CI test count, and marks the migration checklist as completed.

  • Packages:
    • @packages/v8-snapshot-require:
      • Replace Mocha/Chai with Vitest in test files (expect(...).toEqual/toBe, add vitest imports).
      • Add vitest.config.ts (Node env, globals, include test/**/*.spec.ts).
      • Update package.json scripts (test-unit -> vitest run, add test-debug) and devDeps (mocha -> vitest).
  • CI:
    • Adjust sanitize-verify-and-store-mocha-results.expectedResultCount in .circleci/src/pipeline/@pipeline.yml from 9 to 8.
  • Docs:
    • Update guides/esm-migration.md to mark packages/v8-snapshot-require as ✅ completed.

Written by Cursor Bugbot for commit 9860c17. This will update automatically on new commits. Configure here.

@AtofStryker AtofStryker self-assigned this Oct 8, 2025
Copy link

cypress bot commented Oct 8, 2025

cypress    Run #66333

Run Properties:  status check failed Failed #66333  •  git commit 9860c1752c: chore: convert v8-snapshot-require tests to vitest
Project cypress
Branch Review chore/convert_v8_snapshot_require_vitest
Run status status check failed Failed #66333
Run duration 20m 27s
Commit git commit 9860c1752c: chore: convert v8-snapshot-require tests to vitest
Committer Bill Glesias
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 15
Tests that did not run due to a developer annotating a test with .skip  Pending 1102
Tests that did not run due to a failure in a mocha hook  Skipped 4
Tests that passed  Passing 26706
View all changes introduced in this branch ↗︎

Warning

Partial Report: The results for the Application Quality reports may be incomplete.

UI Coverage  45.53%
  Untested elements 184  
  Tested elements 158  
Accessibility  97.97%
  Failed rules  4 critical   8 serious   2 moderate   2 minor
  Failed elements 101  

Tests for review

Failed  cypress/e2e/studio/studio.cy.ts • 1 failed test • app-e2e

View Output

Test Artifacts
Cypress Studio > updates an existing test with assertions Test Replay Screenshots
Flakiness  commands/files.cy.js • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
... > throws when there is an error reading the file Test Replay
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-electron

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots
Flakiness  e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary Test Replay
Flakiness  issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output

Test Artifacts
issue 28527 > fails and then retries and verifies about:blank is not displayed Test Replay Screenshots

The first 5 flaky specs are shown, see all 15 specs in Cypress Cloud.

@AtofStryker AtofStryker force-pushed the chore/convert_v8_snapshot_require_vitest branch from 5d84ef9 to 9860c17 Compare October 9, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant