[DRAFT] dependency: Electron update (38)

[jennifer-shehane]

• Closes

Additional details

Steps to test

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

---

Note

Bumps Electron to 38.5.0, syncs Node to 22.20.0, updates CI/docker images and @types/node, and adjusts prebuilds/node-abi and system tests accordingly.

• Core dependencies
  • Upgrade electron to 38.5.0
  • Update node-abi resolution to 4.17.0
  • Change better-sqlite3 prebuild target to Electron 38.5.0
• Node version alignment
  • Set .node-version and .nvmrc to 22.20.0
  • Update engines.node to >=22.20.0
  • Bump @types/node to 22.19.0 across packages
• CI/CD and Docker
  • Switch CircleCI base images to cypress/base-internal:22.20.0-{trixie,yarn-berry,glibc-2.31}
  • Update docker-compose.yml ci image to 22.20.0-trixie
  • Adjust workflow filter branch to electron-bump-version
• Tests
  • Update system test Docker images to 22.20.0
• Docs/Rules
  • Tweak packages/electron/.cursor/rules/electron-upgrade.mdc wording and changelog templates.

^{Written by Cursor Bugbot for commit 571ad91. This will update automatically on new commits. Configure here.}

[cursor]

Bug: Inconsistent Branch Name Breaks Artifact Persistence

The workflow filter in @main.yml was changed from 'chore/remove_unused_anchors' to 'electron-bump-version', but the setup_should_persist_artifacts command still references the old branch name 'chore/remove_unused_anchors'. This inconsistency means artifacts will persist for the old branch name but not for the new 'electron-bump-version' branch, breaking the intended workflow behavior.

.circleci/src/pipeline/@pipeline.yml#L118-L119

cypress/.circleci/src/pipeline/@pipeline.yml

Lines 118 to 119 in e95bd53

	echo "Setting SHOULD_PERSIST_ARTIFACTS variable"
	echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "chore/remove_unused_anchors" ]]; then

 

---

[cursor]

Bug: Stale branch reference in persist artifacts logic

The setup_should_persist_artifacts command still references fix/angular_dep_resolution_windows in its condition, but the workflow filters have been updated to use electron-bump-version instead. This creates an inconsistency where the electron-bump-version branch will run the full pipeline but won't persist artifacts because the command doesn't recognize it. The condition should be updated to match the new branch name used in the workflow filters.

.circleci/src/pipeline/@pipeline.yml#L118-L123

cypress/.circleci/src/pipeline/@pipeline.yml

Lines 118 to 123 in 571ad91

	setup_should_persist_artifacts:
	steps:
	- run:
	name: Set environment variable to determine whether or not to persist artifacts
	command: |
	echo "Setting SHOULD_PERSIST_ARTIFACTS variable"

 

---