fix: inject HTML before <script> if top-level #32982
Draft
+76
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Member
|
@alexsch01 Can you provide the failing example of this (just a static html file is fine even)? Curious how this problem manifests. |
Contributor
Author
I discovered this when manually testing #32925 <script>
console.log(1, XMLHttpRequest.prototype.open.toString())
</script>
<html>
<head>
<script>
console.log(2, XMLHttpRequest.prototype.open.toString())
</script>
</head>
</html>the console log with 1 will be the original unmodified version I added a unit test |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
alexsch01
changed the title
Contributor
Author
|
@jennifer-shehane if there's a commented <script> tag, this breaks, marking as draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Injects the Cypress payload before a top‑level
<script>appearing before<html>, adds unit tests for edge cases, and updates the changelog.packages/proxy/lib/http/util/rewriter.ts)<script>before<html>and injects payload before it (scriptRe,isScriptTopLevel).html()to accept optionalmockedHtmlToInjectfor testing and adjusts injection order.packages/proxy/test/unit/http/util/rewriter.spec.tscovering top‑level and nested<script>scenarios.<script>appears before<html>incli/CHANGELOG.md.Written by Cursor Bugbot for commit 51eee94. This will update automatically on new commits. Configure here.