chore: add knip health checks to repo #32994
Open
+735
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| - install-required-node | ||
| - run: | ||
| name: Health Check (Knip) | ||
| command: yarn health-check |
There was a problem hiding this comment.
Bug: Missing root health-check script for CI
The CircleCI job runs yarn health-check but no health-check script exists in the root package.json. Only the cli workspace defines this script as knip --workspace cli, which would only check the cli workspace. The root package needs a script like health-check: "knip" to run knip across all workspaces defined in knip.json, similar to how check-ts is defined as yarn lerna run check-ts.
cypress
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
knip-integration
|
| Run status |
|
| Run duration | 18m 46s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
14
|
Pending
|
1098
|
Skipped
|
4
|
Passing
|
26695
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.61%
|
|
|---|---|
|
Untested elements
|
187
|
|
Tested elements
|
161
|
Accessibility
98%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
101
|
Tests for review
studio-ui.cy.ts • 1 failed test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress Studio - UI and Panel Management > studio AI is marked as coming soon |
Test Replay
Screenshots
|
|
studio-state-management.cy.ts • 1 failed test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress Studio - State Management > remains in studio mode when the test name is changed on the file system and file watching is disabled |
Test Replay
Screenshots
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| ... > throws when foo cannot resolve |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome:beta
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/waiting.cy.js • 2 flaky tests • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when route is never resolved |
Test Replay
|
|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary |
Test Replay
|
|
The first 5 flaky specs are shown, see all 13 specs in Cypress Cloud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Adds a Knip-based repository health check with a new CI job and configuration, integrates it into PR/main workflows, and updates scripts/dependencies.
health-checkjob runningyarn health-check(Knip) in.circleci/src/pipeline/@pipeline.yml.health-checkinworkflows/@main.ymlandworkflows/pull-request.ymlafterbuild; gateready-to-releaseonhealth-check.knip.jsonconfiguration at the repo root.package.json: addknipdev dependency.cli/package.json: addhealth-checkscript (knip --workspace cli); remove legacy dependency-check script/dependency.packages/data-context/package.json: add dev dependency@jest/globals.yarn.lockfor new/updated packages (Knip and transitive deps).Written by Cursor Bugbot for commit de48f41. This will update automatically on new commits. Configure here.