chore: fix results formatting for missing totalDuration

[MikeMcC399]

Issue

Offline linting shows a violation of the ESLint rule no-constant-binary-expression for

github-action/index.js

Line 902 in 8c73325

`${testResults.totalDuration / 1000}s` || ''

If testResults.totalDuration is undefined, then

``${testResults.totalDuration / 1000}s || ''

produces NaNs not an empty string.

Change

If testResults.totalDuration is undefined, then fallback to default of displaying 0s.

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[MikeMcC399]

Verification

"Duration" is still correctly displayed when it is available:

Normally "Duration" should always be available, so the corrected code only comes into play if there is an error elsewhere.

[jennifer-shehane]

Thanks! Good catch.

[MikeMcC399]

@jennifer-shehane

Thanks! Good catch.

I will start to add some built-in linting to the repo as the next step. I would not have caught this without ESLint!

[github-actions]

🎉 This PR is included in version 6.7.13 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀