docs: modify contributing to exclude Windows for action rebuild#1669
Merged
mschile merged 1 commit intocypress-io:masterfrom Mar 1, 2026
Merged
docs: modify contributing to exclude Windows for action rebuild#1669mschile merged 1 commit intocypress-io:masterfrom
mschile merged 1 commit intocypress-io:masterfrom
Conversation
|
mschile
approved these changes
Mar 1, 2026
|
🎉 This PR is included in version 7.1.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Situation
CONTRIBUTING > Windows users contains instructions for rebuilding the action on a Windows development system.
Rebuilding with the
buildscriptncc build -o dist index.jsproduces different results under Windows 11 25H2 and Node.js 24.14.0 compared to under Ubuntu 24.04.4 LTS.The workflow check-dist.yml runs under
ubuntu-24.04and consequently fails for checks on branches / PR submitted from Windows.Note also vercel/ncc#1308 which describes how ncc fails to run its own CI test under Node.js 24 and Windows.
Change
Modify CONTRIBUTING > Windows users to exclude rebuilding the action on a Windows development system.