Skip to content

docs: modify contributing to exclude Windows for action rebuild#1669

Merged
mschile merged 1 commit intocypress-io:masterfrom
MikeMcC399:docs/no-rebuild-on-windows
Mar 1, 2026
Merged

docs: modify contributing to exclude Windows for action rebuild#1669
mschile merged 1 commit intocypress-io:masterfrom
MikeMcC399:docs/no-rebuild-on-windows

Conversation

@MikeMcC399
Copy link
Copy Markdown
Collaborator

Situation

CONTRIBUTING > Windows users contains instructions for rebuilding the action on a Windows development system.

Rebuilding with the build script ncc build -o dist index.js produces different results under Windows 11 25H2 and Node.js 24.14.0 compared to under Ubuntu 24.04.4 LTS.

The workflow check-dist.yml runs under ubuntu-24.04 and consequently fails for checks on branches / PR submitted from Windows.

Note also vercel/ncc#1308 which describes how ncc fails to run its own CI test under Node.js 24 and Windows.

Change

Modify CONTRIBUTING > Windows users to exclude rebuilding the action on a Windows development system.

@MikeMcC399 MikeMcC399 added the documentation Improvements or additions to documentation label Mar 1, 2026
@MikeMcC399 MikeMcC399 self-assigned this Mar 1, 2026
@cypress-app-bot
Copy link
Copy Markdown

@MikeMcC399 MikeMcC399 marked this pull request as ready for review March 1, 2026 12:02
@mschile mschile merged commit d0564b1 into cypress-io:master Mar 1, 2026
86 checks passed
@MikeMcC399 MikeMcC399 deleted the docs/no-rebuild-on-windows branch March 1, 2026 15:48
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 7.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants