Draft
Conversation
8cd3121 to
6c4f2c7
Compare
- adds tests for the "path to rad binary" setting - adds cleanup logic to the onboarding suite - updates config to run onboarding and settings suites sequentially - updates e2e ci workflow to ensure both platforms run regardless of each other's outcome Signed-off-by: Zacharias Fragkiadakis <zacfragkiadakis@gmail.com>
- Adds test for the "path to node home" setting
- Allows skipping tests based on platform by including `@skip{platform}CI` in the test name
Signed-off-by: Zacharias Fragkiadakis <zacfragkiadakis@gmail.com>
- Sets "waitFor" timeout globally - Extracts some functions to helper files - Generally cleans up the test suite Signed-off-by: Zacharias Fragkiadakis <zacfragkiadakis@gmail.com>
Signed-off-by: Zacharias Fragkiadakis <zacfragkiadakis@gmail.com>
Signed-off-by: Zacharias Fragkiadakis <zacfragkiadakis@gmail.com>
Signed-off-by: Zacharias Fragkiadakis <zacfragkiadakis@gmail.com>
cd59c8d to
f36a2e9
Compare
Signed-off-by: Zacharias Fragkiadakis <zacfragkiadakis@gmail.com>
- Adds patch details view tests for: - updating the patch status - updating the patch title and description Signed-off-by: Zacharias Fragkiadakis <zacfragkiadakis@gmail.com>
Signed-off-by: Zacharias Fragkiadakis <zacfragkiadakis@gmail.com>
f36a2e9 to
fda6501
Compare
Collaborator
Author
|
@maninak As discussed previously, I've written the tests in a state I believe they would pass, if I could get the patch details screen open. I did manage to find the reason I couldn't open the "patch details" screen though (using the recording logic from #175). It turns out the extension isn't picking up httpd, so the item I was expecting to have the button, was just the "please ensure httpd is running" text. I've skipped the suite in case you want to merge this in one form or another. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test verifying global reactivity for