Add webgl edge guard in texture getter#3403
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds validation for invalid edges in the WebGL renderer to prevent script errors when rendering edges with invalid geometry data. The change addresses issue #3365 where edges with invalid points were causing rendering errors.
- Introduces an edge validation guard in the texture drawing method
- Refactors existing edge validation logic into a reusable helper method
- Prevents rendering of edges with invalid geometric data (badLine, null allpts, or NaN coordinates)
maxkfranz
added a commit
that referenced
this pull request
Aug 12, 2025
…bgl-invalid-pts Add webgl edge guard in texture getter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-references to related issues. If there is no existing issue that describes your bug or feature request, then create an issue before making your pull request.
Associated issues:
Notes re. the content of the pull request. Give context to reviewers or serve as a general record of the changes made. Add a screenshot or video to demonstrate your new feature, if possible.
ElementDrawingWebGL.drawTexture()for invalid edges.Checklist
Author:
unstable. Bug-fix patches can go on eitherunstableormaster.index.d.tsTypescript definition file has been appropriately updated.Reviewers:
masterbranch and theunstablebranch. Normally, this just requires cherry-picking the corresponding merge commit frommastertounstable-- or vice versa.