Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses reconstruction reliability and dependency compatibility by updating SLURM defaults for reconstruction submissions and changing how waveorder is sourced.
Changes:
- Switch the default SLURM partition for inverse transfer function reconstruction jobs from
preemptedtocpu. - Update
waveorderdependency from a pinned pre-release (3.0.0a2) to a GitHub-sourced install.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pyproject.toml |
Switches waveorder to a VCS dependency to avoid the pinned version incompatibility. |
biahub/apply_inverse_transfer_function.py |
Changes the default SLURM partition for these reconstruction jobs to cpu. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ieivanov
reviewed
Feb 28, 2026
| "submitit", | ||
| "torch", | ||
| "tqdm", | ||
| "waveorder==3.0.0a2", |
Collaborator
There was a problem hiding this comment.
We have a 3.0.0 release from 3 weeks ago - would that work, instead of using the main branch?
mattersoflight
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cpu3.0.0a2releaseTest plan
cpupartition