Skip to content

Reconstruction bug fixes#205

Merged
mattersoflight merged 2 commits intomainfrom
reconstruction_bug_correction
Feb 28, 2026
Merged

Reconstruction bug fixes#205
mattersoflight merged 2 commits intomainfrom
reconstruction_bug_correction

Conversation

@tayllatheodoro
Copy link
Collaborator

@tayllatheodoro tayllatheodoro commented Feb 27, 2026

Summary

  • Fix reconstruct jobs failing when the preempted SLURM partition is stopped by switching the default partition to cpu
  • Fix waveorder version incompatibility by pointing to the latest version from the GitHub repository instead of the pinned 3.0.0a2 release

Test plan

  • Verify reconstruction jobs submit and run successfully on the cpu partition
  • Verify waveorder imports correctly and reconstruction runs without compatibility errors

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses reconstruction reliability and dependency compatibility by updating SLURM defaults for reconstruction submissions and changing how waveorder is sourced.

Changes:

  • Switch the default SLURM partition for inverse transfer function reconstruction jobs from preempted to cpu.
  • Update waveorder dependency from a pinned pre-release (3.0.0a2) to a GitHub-sourced install.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pyproject.toml Switches waveorder to a VCS dependency to avoid the pinned version incompatibility.
biahub/apply_inverse_transfer_function.py Changes the default SLURM partition for these reconstruction jobs to cpu.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"submitit",
"torch",
"tqdm",
"waveorder==3.0.0a2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a 3.0.0 release from 3 weeks ago - would that work, instead of using the main branch?

@mattersoflight mattersoflight merged commit ce596fe into main Feb 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants