Skip to content

Skip assigning axes in MouseManipulator if already assigned programmatically #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
d-buchmann wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Skip assigning axes in MouseManipulator if already assigned programmatically #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f8db91
Skip assigning axes if the user already did
d-buchmann Jul 16, 2021
97a5b4f
Make PlotManipulator more flexible
d-buchmann Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Source/OxyPlot/PlotController/Manipulators/MouseManipulator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@ protected MouseManipulator(IPlotView plotView)
/// <param name="e">The <see cref="OxyInputEventArgs" /> instance containing the event data.</param>
public override void Started(OxyMouseEventArgs e)
{
this.AssignAxes(e.Position);
if (this.XAxis == null || this.YAxis == null)
this.AssignAxes(e.Position);
base.Started(e);
this.StartPosition = e.Position;
}
}
}
}
6 changes: 3 additions & 3 deletions Source/OxyPlot/PlotController/Manipulators/PlotManipulator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ protected PlotManipulator(IPlotView view)
/// Gets or sets the X axis.
/// </summary>
/// <value>The X axis.</value>
protected Axis XAxis { get; set; }
public Axis XAxis { get; set; }

/// <summary>
/// Gets or sets the Y axis.
/// </summary>
/// <value>The Y axis.</value>
protected Axis YAxis { get; set; }
public Axis YAxis { get; set; }

/// <summary>
/// Transforms a point from screen coordinates to data coordinates.
Expand Down Expand Up @@ -88,4 +88,4 @@ protected void AssignAxes(ScreenPoint position)
this.YAxis = yaxis;
}
}
}
}