-
Notifications
You must be signed in to change notification settings - Fork 42
feat: allow using specific formatters for tracing #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d-e-s-o
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. It fails to build with cargo check --tests --no-default-features --features=trace. Please also revert spurious formatting changes.
In general I am not yet sold on us wanting such a change. There are more configurations available and there could be a case made for configurability of all of them -- and such support will add complexity with very little use. At the end of the day, who cares what format is being used for a given test. If it was for programmatic evaluation using JSON, perhaps there would be a stronger case. But again we run into similar problems to the above where an additional feature is required and it is rather cumbersome to enable that.
|
Sure, let me take a look and fix those issues.
I do, the default format of tracing feels quite unreadable. Using "pretty" at least gives some simple lines, allow to grep away the nested stuff. |
They seem to come from running |
|
Fixed the issue with Also reverted the changes from |
That change only fixed it for the command line. Not for a dependency. I'll need to take another look. |
Looks good now. |
|
Thanks for the feature proposal. After some back and forth, I have decided to pass on this functionality: the complexity of the additional conditional compilation seems too high for such a niche feature (nobody has asked for it thus far) and there is no clear line to be drawn between these fixed formats and a fully blown language of sorts for making everything that |
No description provided.