Skip to content

Conversation

@egenender
Copy link
Contributor

Whenever voting starts, players don't know if a fellow player has voted. For each voting, players have to wait for every other player to vote.
This change tries to make it easier for players to know which player hasn't voted.
The bot will send a message to the group for each player that actually votes, and players, knowing which players havn't vote, can take the proper actions to continue the game.

Whenever voting starts, players don't know if a fellow player has voted. For each voting, players have to wait for every other player to vote.
This change tries to make it easier for players to know which player hasn't voted.
The bot will send a message to the group for each player that actually votes, and players, knowing which players havn't vote, can take the proper actions to continue the game.
@egenender
Copy link
Contributor Author

you may want to use
callback.from_user.uid
instead of
callback.from_user.first_name

@d0tcc
Copy link
Owner

d0tcc commented Sep 8, 2017

I encountered this problem in some of the many games I played with the bot: someone isn’t paying attention and then the whole game is interrupted. I thought about a timer but couldn’t decide what to do once the timer is out. this is no scenario that exists in the board game. the problem with your suggestion is that it could be used to gather further information. if someone votes “nein” really fast it sometimes tells you something about their role. additionally the command would often not solve the problem, because if someone is not paying attention then it wouldn’t help if everyone else would know who this person is.

i wanted to stay as close to the original game as possible so I didn’t implement the feature...

@egenender
Copy link
Contributor Author

I understand your concern.
Just to clarify, the wouldn't tell players if the vote is JA! o NEIN!, it only displays if the player voted or not.
I took this idea from the werewolfbot, it displays who voted and has a timer, but that wouldn't be useful here, because in Secret Hitler, every vote counts.
I'll explore other options and maybe make a new PR.

@egenender
Copy link
Contributor Author

At the moment, I may have two non-exclusive solutions.

  1. Add a command that displays who voted and who didn't. This could also include a timer. For example, if you try to see who voted and there hasn't been 5 minutes since the candidacy, it would tell you to wait at least for the 5 minute period. Then, it will inform you who voted and who is missing.
  2. Same solution as the original PR, but configurable by a setting. That way, the game is unchanged under one configuration, and, if you wish to, you can change the configuration to actually display who voted in real time [just because this is the way the groups I've played with prefers to; and we know nobody would take advantage of the mere fact that someone did or did not decide its vote yet]

@HQ063
Copy link

HQ063 commented Sep 8, 2017

I like solution #1

@leviatas
Copy link
Contributor

leviatas commented Sep 8, 2017

I like solution 1 as well.

@d0tcc
Copy link
Owner

d0tcc commented Sep 14, 2017

solution 1 by @egenender seems like a good compromise for this problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants