This repository was archived by the owner on Oct 23, 2024. It is now read-only.
use container ports in tasks SRV records#519
Open
vixns wants to merge 12 commits intod2iq-archive:masterfrom
Open
use container ports in tasks SRV records#519vixns wants to merge 12 commits intod2iq-archive:masterfrom
vixns wants to merge 12 commits intod2iq-archive:masterfrom
Conversation
|
Can one of the admins verify this patch? |
jdef
reviewed
May 8, 2018
Contributor
jdef
left a comment
jdef
left a comment
There was a problem hiding this comment.
Thanks for the PR. Couple of suggestions:
- Please add unit tests that cover the port mapping case. Record generation is complicated and we rely on unit tests to help guard against accidental breakage.
- Does this work the same for both Docker- and UCR-containerized tasks? If not, can you make it do so?
- This will break in clusters where people are assuming SRV always points to the host port. Please gate this functionality behind a configuration flag that defaults to the current, host-port based behavior.
- Is there a relationship between this code and the value of the config
IPSources? If so, that should be very clearly documented so that people aren't fighting confusing configuration combinations.
Author
|
|
Contributor
|
SRVPreferContainerPorts ?
…On Tue, May 8, 2018 at 8:16 AM, vixns ***@***.***> wrote:
UseContainerPorts is not a good name, SRVTaskRecordsUseContainerPort
sWithNetinfo has a better semantic, but may be too long, any idea for a
better option name ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#519 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACPVLNVFzvxHjE-X_sbjCPGLdDcaPes0ks5twYy7gaJpZM4T2Y79>
.
|
|
Can one of the admins verify this patch? |
Mesos has deprecated/removed the /state.json endpoint and has replaced it with /state. This patch updates the url path from /state.json to /state
Author
|
oops rebased on wrong branch, sorry. Re-rebased and force pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.