feat: support latest nodejs version #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support: latest nodejs version
Member
|
LGTM but the description does not match the actual PR: - node-version: [14.x]
+ node-version: [14.x, 18.x, 20.x, 22.x](and tbh I don't think we need to test against 14.x; even 18.x expires in 3 weeks) |
|
Also it looks like the GitHub actions are not even running? |
Fil
reviewed
Apr 7, 2025
Member
|
They do run, but there's not a lot of activity on this repo. |
|
Oh it's running now. Very nice!
|
Member
|
GitHub Actions only run on pull requests by external contributors when we approve them for security reasons. |
Member
|
I don't see the point for this library of testing against a whole matrix of node versions. Upgrading to 22.x is probably enough. |
Fil
reviewed
Apr 8, 2025
Fil
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our GitHub Actions workflow by upgrading to actions/checkout@v4 and actions/setup-node@v4 (edited) with yarn caching while expanding the Node.js matrix to 22.x (edited) for enhanced compatibility testing.