Skip to content

Separate out retail components from fallback service models#880

Merged
FH-Inway merged 3 commits intod365collaborative:masterfrom
FH-Inway:fix-10.0.41-initial-installation
Mar 2, 2025
Merged

Separate out retail components from fallback service models#880
FH-Inway merged 3 commits intod365collaborative:masterfrom
FH-Inway:fix-10.0.41-initial-installation

Conversation

@FH-Inway
Copy link
Member

@FH-Inway FH-Inway commented Feb 22, 2025

This pull request introduces a new parameter, IncludeFallbackRetailServiceModels, to the Invoke-D365SDPInstall function and related components. This parameter is designed to support backward compatibility when installing updates on local VHDs where information about installed service models may not be available.

Fixes #878

Key changes include:

New Parameter Addition:

  • Added IncludeFallbackRetailServiceModels parameter to Invoke-D365SDPInstall to include fallback retail service models in the topology file. This supports backward compatibility for local VHD installations. [1] [2] [3] [4]

Internal Function Updates:

  • Updated Update-TopologyFile to handle the new IncludeFallbackRetailServiceModels parameter, ensuring retail service models are included when specified. [1] [2] [3]

Script Variables:

  • Separated the fallback installation service model names into core and retail lists. The retail list is included only if the new parameter is specified. [1] [2]

Documentation and Tests:

  • Updated the documentation to include the new parameter in the command examples and parameter descriptions. [1] [2] [3]
  • Added tests to ensure the new parameter is correctly recognized and handled by the Invoke-D365SDPInstall function.

@FH-Inway
Copy link
Member Author

@Splaxi This pr changes the behavior of Invoke-D365SDPInstall in the following scenario: Installing a Microsoft update on a 10.0.39 VHD image for the first time. In this case, the retail components will no longer be updated.

I think this scenario is limited enough in scope to not impact a lot of people. We also have an easy to implement workaround with the new -IncludeFallbackRetailServiceModels parameter for those that would be impacted.
The alternatives would be

  1. implement some logic to detect the scenario and include the retail components in that case
  2. not make the change and direct the people to the workaround documented in Invoke-D365SDPInstall - Unable to stop retail service #878

I'm not really up for spending time on 1 and I'd rather not deal with all the issues caused by 2.

@Splaxi
Copy link
Collaborator

Splaxi commented Mar 1, 2025

Let's go with this 🤘

@FH-Inway FH-Inway merged commit 4c724cc into d365collaborative:master Mar 2, 2025
5 checks passed
@FH-Inway FH-Inway deleted the fix-10.0.41-initial-installation branch March 2, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invoke-D365SDPInstall - Unable to stop retail service

2 participants