standalone-install.sh script improvements#152
Open
byt3farm wants to merge 6 commits intod3vilh:mainfrom
Open
Conversation
byt3farm
commented
Jul 15, 2025
byt3farm
commented
- added detection and warning when script is running as sudo/root because installationscript might fail when ran as root due to PATH issues
- echo detected/found current go version with exact path to go binary for clarity
- add architecture string "arm64"
- cpu architecture detection simplyfied; no redundant wget and tar commands; case construct instead of if/elif/else
- fix: go does not provide any extra binaries for armv7l architecture; need to use compatible armv6l binariesas fallback instead
- print the detected unsupported architecture before script exit
- print output detected architecture and resulted archive file/url to be downloaded
- exit script with error message on wget download error
- remove downloaded archive file after archive extraction
- set go version back to 1.21.5 because install BeeGo v2 (go install github.com/beego/bee/v2@develop) would fail due to multiple build errors with the newer go version 1.22.3
- Cloning qrencode, check if path already exists to avoid git clone fatal error when already cloned
…ause installationscript might fail when ran as root due to PATH issues - add architecture string "arm64" - cpu architecture detection simplyfied; no redundant wget and tar commands; use case construct instead of if/elif/else - echo detected/found current go version with exact path to go binary for clarity - fix golang does not provide binaries for armv7l and use compatible armv6l binariesas fallback instead - print output the detected unsupported architecture version before script exit - print output detected architecture and resulted archive file/url to be downloaded - exit script with error message on wget download error - remove downloaded archive file after archive extraction - set go version back to 1.21.5 because install BeeGo v2 (go install github.com/beego/bee/v2@develop) would fail due to multiple build errors with the newer go version 1.22.3 - Cloning qrencode, check if path already exists to avoid git clone fatal error when already cloned
samveen
reviewed
Aug 28, 2025
|
|
||
| # All the variables | ||
| GOVERSION="1.22.3" | ||
| GOVERSION="1.21.5" |
There was a problem hiding this comment.
This should match the go version from the latest release version, instead of downgrading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.