-
Notifications
You must be signed in to change notification settings - Fork 325
func define allow at back #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
runsys
wants to merge
6
commits into
d5:master
Choose a base branch
from
runsys:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
843b480
fun define at anywhere support
runsys 8f86832
define func at anywhere suport utils
runsys adb77ea
utls func bug fix
runsys f744560
func define aywhere bug fix
runsys 18c2165
func defie anywhere bug fix
runsys 91021d7
make return bool func compare bool no error
runsys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -148,6 +148,30 @@ func (p *Parser) ParseFile() (file *File, err error) { | |
| return nil, p.errors.Err() | ||
| } | ||
|
|
||
| var nass [][]string | ||
| for i := 0; i < len(stmts); i += 1 { | ||
| nas := regexFindAll(stmts[i].String(), "[A-Za-z][a-zA-Z0-9]*(_[a-zA-Z0-9]+)*\\s*[:()]") | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This parser logic based on regex looks quite brittle to me. |
||
| nass = append(nass, nas) | ||
| } | ||
| for i := 0; i < len(nass); i += 1 { | ||
| for j := 0; j < len(nass[i]); j += 1 { | ||
| i1 := i + 1 | ||
| bdo := false | ||
| for ; i1 < len(nass); i1 += 1 { | ||
| if strings.HasSuffix(nass[i1][0], ":") && strings.HasSuffix(nass[i][j], "(") && nass[i1][0][:len(nass[i1][0])-1] == nass[i][j][:len(nass[i][j])-1] { | ||
| nass = AppendManyNew[[]string](nass[:i], nass[i1], nass[i:i1], nass[i1+1:]) | ||
| stmts = AppendManyNew[Stmt](stmts[:i], stmts[i1], stmts[i:i1], stmts[i1+1:]) | ||
| bdo = true | ||
| break | ||
| } | ||
| } | ||
| if bdo { | ||
| i -= 1 | ||
| break | ||
| } | ||
| } | ||
| } | ||
|
|
||
| file = &File{ | ||
| InputFile: p.file, | ||
| Stmts: stmts, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| package parser | ||
|
|
||
| import ( | ||
| "reflect" | ||
| "regexp" | ||
| ) | ||
|
|
||
| func AppendManyNew[T any](v []T, as ...any) []T { | ||
| l := len(v) | ||
| for _, a := range as { | ||
| switch a.(type) { | ||
| case T: | ||
| l += 1 | ||
| case []T: | ||
| l += len(a.([]T)) | ||
| default: | ||
| panic("type error:" + reflect.TypeOf(a).String()) | ||
| } | ||
| } | ||
| n := make([]T, l) | ||
| n = n[:0] | ||
| n = append(n, v...) | ||
| for _, a := range as { | ||
| switch a.(type) { | ||
| case T: | ||
| n = append(n, a.(T)) | ||
| case []T: | ||
| n = append(n, a.([]T)...) | ||
| default: | ||
| panic("type error:" + reflect.TypeOf(a).String()) | ||
| } | ||
| } | ||
| return n | ||
| } | ||
|
|
||
| func regexFindAll(s0, frx s) []s { | ||
| return regexp.MustCompile(frx).FindAllString(s0, -1) | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo?