fixes auto-quote not quoting cells containing quote characters#205
Open
MarkLee131 wants to merge 1 commit intod99kris:masterfrom
Open
fixes auto-quote not quoting cells containing quote characters#205MarkLee131 wants to merge 1 commit intod99kris:masterfrom
MarkLee131 wants to merge 1 commit intod99kris:masterfrom
Conversation
WriteCsv auto-quote logic checks for separator, space and newline in cell content, but does not check for the quote character itself. This causes cells containing quotes (but no separator/space/newline) to be written unquoted and unescaped, producing malformed CSV output that corrupts data on re-read. Add quote character to the auto-quote condition and add test104 to verify round-trip integrity for cells containing quote characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #204:
WriteCsv auto-quote logic checks for separator, space and newline in cell content, but does not check for the quote character itself. This causes cells containing quotes (but no separator/space/newline) to be written unquoted and unescaped, producing malformed CSV output that corrupts data on re-read.
Add quote character to the auto-quote condition and add test104 to verify round-trip integrity for cells containing quote characters.