fixes silent integer truncation for narrow types in Converter#207
Open
MarkLee131 wants to merge 1 commit intod99kris:masterfrom
Open
fixes silent integer truncation for narrow types in Converter#207MarkLee131 wants to merge 1 commit intod99kris:masterfrom
MarkLee131 wants to merge 1 commit intod99kris:masterfrom
Conversation
When converting CSV cell values to signed char, unsigned char, short, or unsigned short, std::stoi returns an int which is then silently truncated via static_cast. For example, "256" read as unsigned char silently becomes 0, and "32768" read as short becomes -32768. Add range checks against std::numeric_limits before the static_cast, throwing std::out_of_range when the value does not fit. Add test104 to verify range checking for all four narrow integer types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #206:
When converting CSV cell values to signed char, unsigned char, short, or unsigned short, std::stoi returns an int which is then silently truncated via static_cast. For example, "256" read as unsigned char silently becomes 0, and "32768" read as short becomes -32768.
Add range checks against std::numeric_limits before the static_cast, throwing std::out_of_range when the value does not fit. Add test104 to verify range checking for all four narrow integer types.