fixes SetColumnName/SetRowName not removing old name from label map#209
Open
MarkLee131 wants to merge 1 commit intod99kris:masterfrom
Open
fixes SetColumnName/SetRowName not removing old name from label map#209MarkLee131 wants to merge 1 commit intod99kris:masterfrom
MarkLee131 wants to merge 1 commit intod99kris:masterfrom
Conversation
SetColumnName and SetRowName add the new name to the internal label map but do not remove the old name. After renaming, the old name still resolves via GetColumnIdx/GetRowIdx, which can cause silent data misdirection when the old name is used after a rename. Remove the old name from the map before inserting the new one. Add test104 to verify old names are properly cleaned up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #208:
SetColumnName and SetRowName add the new name to the internal label map but do not remove the old name. After renaming, the old name still resolves via GetColumnIdx/GetRowIdx, which can cause silent data misdirection when the old name is used after a rename.
Remove the old name from the map before inserting the new one. Add test104 to verify old names are properly cleaned up.