frontend: respect admin role when requested#7817
Merged
mksahakyan merged 2 commits into11.0from Jun 26, 2025
Merged
Conversation
Reorganization of variables and refactoring Acked-by: Tigran Mkrtchyan Target: master Require-book: no Require-notes: no (cherry picked from commit 00e680d) Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Motivation: dCache has two identify admin role: login attribute and RolePrincipal. As HttpServletRequests#isAdmin checks only the RolePrincipal, attribute based roles are ignored. Modification: Update HttpServletRequests#isAdmin to check both principal and login attribute. Added frontend test. Result: Restore expected behaviour. Fixes: #7808 Acked-by: Karen Hoyos Target: master, 11.0, 10.2 Require-book: no Require-notes: yes (cherry picked from commit 7dc561d) Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
dCache has two identify admin role: login attribute and RolePrincipal. As HttpServletRequests#isAdmin checks only the RolePrincipal, attribute based roles are ignored.
Modification:
Update HttpServletRequests#isAdmin to check both principal and login attribute. Added frontend test.
Result:
Restore expected behaviour.
Fixes: #7808
Acked-by: Karen Hoyos
Target: master, 11.0, 10.2
Require-book: no
Require-notes: yes
(cherry picked from commit 7dc561d)