gplazma: enforce RolePrincipal if Role attribute is set #7911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: some parts of dCache use Subject to identify users role, thus require RolePrincipal, others use solo Role attributes. In case of only Role attribute is set the role enforcement doesn't work. Modification: Update GPlazma to set RolePrincipal if Role attribute is set. Result: More consistent role behaviour. Acked-by: Karen Hoyos Target: master, 11.1, 11.0, 10.2 Require-book: no Require-notes: yes (cherry picked from commit c49820e) Signed-off-by: Tigran Mkrtchyan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
some parts of dCache use Subject to identify users role, thus require RolePrincipal, others use solo Role attributes. In case of only Role attribute is set the role enforcement doesn't work.
Modification:
Update GPlazma to set RolePrincipal if Role attribute is set.
Result:
More consistent role behaviour.
Acked-by: Karen Hoyos
Target: master, 11.1, 11.0, 10.2
Require-book: no
Require-notes: yes
(cherry picked from commit c49820e)