webdav: fix range header formatting in relay request #7973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An open-ended range like `bytes=0-` produced an invalid header like "bytes=0-null", resulting in no data being transferred. This patch implements support for open-ended ranges (`bytes=0-`) and suffix ranges (`bytes=-500`). References dCache#7971 Signed-off-by: Martin Zurowietz <info@mzur.de>
Member
|
@mzur |
Member
|
Ah, it's already signed! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An open-ended range like
bytes=0-produced an invalid headerbytes=0-null, resulting in no data being transferred. This patch implements support for open-ended ranges (bytes=0-) and suffix ranges (bytes=-500).I confirmed the fix manually using the local
system-test. I also wanted to add a test case for this but it seemed like this requires a full integration test which could be a little over the top? Could you give me a hint how best to add a test?While testing a suffix range like
bytes=-10(which should return the last 10 bytes) I may have found another bug. The response returns the correct data but has the headersContent-Range: bytes 0-10/761andContent-Length: 11which seem incorrect.References #7971