core: Inode: Provide helper method create Inode from Opaque fileIdKey

This decouples the last bit of the remaining byte[] logic from Opaque.

Related: #149
Signed-off-by: Christian Kohlschütter <[email protected]>

Author: kohlschuetter

core/src/main/java/org/dcache/nfs/v4/FileTracker.java

@@ -565,7 +565,7 @@ void removeOpen(Inode inode, stateid4 stateid) {
     public Map<Inode, Collection<NFS4Client>> getOpenFiles() {
         return files.entrySet().stream()
                 .collect(Collectors.toMap(
-                        e -> Inode.forFile(e.getKey().asBytes()),
+                        e -> Inode.forFileIdKey(e.getKey()),
                         e -> e.getValue().stream().map(OpenState::getClient).collect(Collectors.toSet())));
     }
 
@@ -578,7 +578,7 @@ public Map<Inode, Collection<NFS4Client>> getOpenFiles() {
     public Map<Inode, Collection<NFS4Client>> getDelegations() {
         return delegations.entrySet().stream()
                 .collect(Collectors.toMap(
-                        e -> Inode.forFile(e.getKey().asBytes()),
+                        e -> Inode.forFileIdKey(e.getKey()),
                         e -> e.getValue().stream().map(DelegationState::client).collect(Collectors.toSet())));
     }
 }

core/src/main/java/org/dcache/nfs/vfs/Inode.java

@@ -144,6 +144,10 @@ public static Inode forFile(byte[] bytes) {
         return new Inode(0, 0, 0, bytes);
     }
 
+    public static Inode forFileIdKey(Opaque key) {
+        return forFile(key.asBytes());
+    }
+
     @Deprecated(forRemoval = true)
     public byte[] getFileId() {
         return opaqueKey.asBytes();