Skip to content

core: Return BAD_STATEID for NFSv4.0 special "stateless" stateids #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+11 −0
Closed

core: Return BAD_STATEID for NFSv4.0 special "stateless" stateids #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions core/src/main/java/org/dcache/nfs/v4/NFSv4StateHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,17 @@ public NFS4Client getClient(clientid4 clientid) throws StaleClientidException {
}

public NFS4Client getClientIdByStateId(stateid4 stateId) throws ChimeraNFSException {
if (Stateids.isStateLess(stateId)) {
// We do not support NFSv4.0 Anonymous/Bypass Stateids:
// https://datatracker.ietf.org/doc/html/rfc7530#section-9.1.4.3
//
// This is occasionally used by macOS NFS when it loses track of its state.
// Returning BAD_STATEID forces a connection-restart.
//
// https://github.com/apple-oss-distributions/NFS/blob/NFS-327.120.3/kext/nfs4_vnops.c#L2813
// https://github.com/apple-oss-distributions/NFS/blob/NFS-327.120.3/kext/nfs4_vnops.c#L1863L1880
throw new BadStateidException();
}

_readLock.lock();
try {
Expand Down