-
Notifications
You must be signed in to change notification settings - Fork 41
feat: add seed-safe-area-bottom in overlay components #1053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 3e3646f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 Walkthrough워크스루BottomSheet 및 MenuSheet 컴포넌트의 Content 슬롯에 안전 영역 하단(safe-area-bottom) 패딩을 추가하는 변경사항입니다. 기존 로직은 유지되며, 화면 하단의 시스템 UI 영역을 고려한 스타일 업데이트입니다. 변경 사항
예상 코드 리뷰 노력🎯 2 (Simple) | ⏱️ ~8분
시
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (4)
packages/css/all.cssis excluded by!packages/css/**/*packages/css/all.min.cssis excluded by!packages/css/**/*packages/css/recipes/bottom-sheet.cssis excluded by!packages/css/**/*packages/css/recipes/menu-sheet.cssis excluded by!packages/css/**/*
📒 Files selected for processing (3)
.changeset/smart-bags-look.md(1 hunks)packages/qvism-preset/src/recipes/bottom-sheet.ts(1 hunks)packages/qvism-preset/src/recipes/menu-sheet.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Analyze (javascript)
- GitHub Check: chromatic-deployment
- GitHub Check: Deploy Seed Design V3 Docs
🔇 Additional comments (2)
.changeset/smart-bags-look.md (1)
1-5: LGTM!changeset 포맷과 내용이 적절합니다. Content slot에 safe area를 추가하는 변경사항이 정확히 문서화되어 있습니다.
packages/qvism-preset/src/recipes/bottom-sheet.ts (1)
86-86: CSS 변수가 정상적으로 정의되어 있으며, 변경사항이 적절합니다.
--seed-safe-area-bottomCSS 변수는packages/qvism-preset/src/global.ts에서 잘 정의되어 있고, 다양한 브라우저 지원 레벨에 맞는 폴백값(constant, env)을 포함하고 있습니다.콘텐츠 슬롯에 안전 영역을 추가한 것은 다음과 같은 이유로 적절합니다:
- 콘텐츠 슬롯은
flex: 1로 설정되어 있어 스크롤 가능한 영역입니다menu-sheet.ts(line 67)와app-screen.ts(line 161)에서 동일한 패턴으로 안전 영역을 적용하고 있습니다- footer 슬롯은 고정된 패딩값을 사용하도록 의도적으로 설계되었으며, 이는 현재 설정이 정확함을 나타냅니다
Deploying seed-design-v3 with
|
| Latest commit: |
3e3646f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://133bb9c1.seed-design.pages.dev |
| Branch Preview URL: | https://feat-bottom-overlay-componen.seed-design.pages.dev |
Summary by CodeRabbit
릴리스 노트
✏️ Tip: You can customize this high-level summary in your review settings.