feat: remove rounded option, add border-radius prop#1201
Merged
junghyeonsu merged 8 commits intodevfrom Feb 9, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 7c350f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📝 WalkthroughWalkthroughImageFrame API가 boolean Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.changeset/tasty-masks-guess.md:
- Line 7: 수정된 변경 로그의 오타를 바로잡아 주세요: 설명에서 "ImageFrmae"를 찾아 "ImageFrame"으로 교정하고
문장(예: "ImageFrame `rounded` 옵션을 제거하고, borderRadius를 받을 수 있게 변경합니다")이 자연스럽게 읽히도록
띄어쓰기/마침표도 점검하여 사용자-facing 변경 로그로 적절히 다듬어 주세요.
🧹 Nitpick comments (1)
docs/examples/react/image-frame/border-radius.tsx (1)
8-74: alt 텍스트 형식 일관성 개선을 고려해 주세요.alt 텍스트 형식이 약간 불일치합니다:
- Line 12:
"size 20 borderRadius=r1"(등호 사용)- Line 24:
"size 24 borderRadius r1"(공백 사용)일관된 형식으로 통일하면 좋겠습니다.
♻️ alt 텍스트 형식 통일 제안
- alt="size 20 borderRadius=r1" + alt="size 20 borderRadius r1"또는 모든 alt 텍스트에 동일한 형식을 적용하세요.
Deploying seed-design-v3 with
|
| Latest commit: |
7c350f0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://93845768.seed-design.pages.dev |
| Branch Preview URL: | https://feat-image-frame-border-radi.seed-design.pages.dev |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…ed-design into feat/image-frame-border-radius
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/rootage/components/image-frame.yaml`:
- Around line 34-38: The deprecation message for the `rounded` option is
incorrect: for users who set `rounded=false` (intending square corners) the
guidance to use `borderRadius="r2"` would make corners rounded; update the
deprecation text in the "false" case of the `rounded` option in image-frame.yaml
to instruct users to either omit `borderRadius` or set it to a value that yields
square corners (or explicitly `borderRadius="none"` / the component's
non-rounded default), and change the explanatory sentence to clarify that
`borderRadius` now controls corner styling and that no prop (or the explicit
non-rounded value) preserves the original square behavior.
🧹 Nitpick comments (1)
packages/rootage/components/image-frame.yaml (1)
17-19:cornerRadius설명이 deprecated된rounded옵션에 종속되어 있습니다.현재 설명이 "rounded 옵션 사용 시 적용되는 모서리 반경입니다"로 되어 있는데, PR 목적상
borderRadiusprop이 새로운 방식이므로 설명을 좀 더 일반적으로 수정하는 것이 좋겠습니다.📝 수정 제안
cornerRadius: type: dimension - description: rounded 옵션 사용 시 적용되는 모서리 반경입니다. + description: 이미지 프레임의 모서리 반경입니다.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/qvism-preset/src/recipes/image-frame.ts`:
- Around line 6-17: Remove the top-level borderRadius: "inherit" from the base
style object so the component doesn't unintentionally inherit the parent's
radius; keep (or add) borderRadius: "inherit" only on the child selector "& >
img, & > video" so only the media elements inherit rounding, and ensure any
prop-based rounding (e.g., a rounded prop handler) applies to the wrapper rather
than relying on base to inherit from parent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
새로운 기능
리팩터
문서
잡일