feat(react,css,rootage): adjust BottomSheet title padding and layout styling#1207
feat(react,css,rootage): adjust BottomSheet title padding and layout styling#1207junghyeonsu merged 12 commits intodevfrom
Conversation
🦋 Changeset detectedLatest commit: c5bc403 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughBottomSheet의 제목·설명 패딩과 word-break 설정을 title로 이동하고, React 컴포넌트가 Drawer 컨텍스트의 닫기 버튼 렌더 상태를 Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 시
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying seed-design-v3 with
|
| Latest commit: |
c5bc403
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ff776f68.seed-design.pages.dev |
| Branch Preview URL: | https://feat-bottom-sheet-header-tit.seed-design.pages.dev |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/react/src/components/BottomSheet/BottomSheet.tsx`:
- Around line 67-79: BottomSheetTitle currently spreads {...props} after the
internal data-show-close-button prop, allowing consumer props to overwrite the
context-derived value; update the JSX in the forwardRef render so that
{...props} is applied before the explicit data-show-close-button (the component
using Drawer.Title and the useDrawerContext call), ensuring the internal
data-show-close-button computed from useDrawerContext always takes precedence
over consumer-supplied props.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/rootage/components/bottom-sheet.yaml`:
- Around line 142-148: Replace the hardcoded "50px" values under the title
paddingRight (and title paddingLeft/paddingRight inside headerAlignment=center
-> enabled) with a design token; either switch to the nearest existing token
($dimension.x12 or $dimension.x13), or add a new token (e.g. $dimension.x12_5 =
50px) and use that token; confirm whether the intended size is exactly 50px and
then apply the chosen token consistently to the title.paddingRight and
headerAlignment=center.enabled.title.paddingLeft/paddingRight entries.
🧹 Nitpick comments (1)
examples/stackflow-spa/src/activities/ActivityBottomSheetModalTest.tsx (1)
28-33: LGTM!닫기 버튼 표시 활성화가 PR의 BottomSheet 레이아웃/패딩 변경 사항과 잘 연동되어 테스트 목적에 부합합니다.
선택적으로, boolean prop은 간결하게 작성할 수 있습니다:
- showCloseButton={true} + showCloseButton
Summary by CodeRabbit
버그 수정
신규/개선
스타일/설정