-
Notifications
You must be signed in to change notification settings - Fork 111
fix(plugin-basic-ui): Fix a bug that entrance transitions are not applied #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: ac733d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedThe pull request is closed. 📝 WalkthroughSummary by CodeRabbit
WalkthroughApplies a bug fix in plugin-basic-ui by altering how AppScreen computes the transition state used for styling: uses lazyTransitionState for intermediate states and raw transitionState for “enter-done”/“exit-done.” Adds a patch changeset entry for @stackflow/plugin-basic-ui. Changes
Sequence Diagram(s)sequenceDiagram
participant TransitionSource as Transition Source
participant AppScreen as AppScreen Component
participant CSS as css.appScreen
TransitionSource->>AppScreen: transitionState, lazyTransitionState
AppScreen->>AppScreen: compute state = (enter-done/exit-done ? transitionState : lazyTransitionState)
AppScreen->>CSS: css.appScreen(state)
CSS-->>AppScreen: className
AppScreen-->>TransitionSource: render with updated classes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
commit: |
No description provided.