Skip to content

feat(config, react): Remove first class data loader cache #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ENvironmentSet merged 3 commits into from
Dec 15, 2025
Merged

feat(config, react): Remove first class data loader cache #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c264305
remove cache
Dec 15, 2025
70f3b82
add cs
Dec 15, 2025
ff59bb4
revert demo changes
Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/real-cats-rest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@stackflow/react": major
"@stackflow/config": major
---

Remove data loader cache
15 changes: 4 additions & 11 deletions config/src/ActivityLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,12 @@
import type { ActivityLoaderArgs } from "./ActivityLoaderArgs";
import type { RegisteredActivityName } from "./RegisteredActivityName";

export type ActivityLoader<ActivityName extends RegisteredActivityName> = {
(args: ActivityLoaderArgs<ActivityName>): any;
loaderCacheMaxAge?: number;
};
export type ActivityLoader<ActivityName extends RegisteredActivityName> = (
args: ActivityLoaderArgs<ActivityName>,
) => any;

export function loader<ActivityName extends RegisteredActivityName>(
loaderFn: (args: ActivityLoaderArgs<ActivityName>) => any,
options?: {
loaderCacheMaxAge?: number;
},
): ActivityLoader<ActivityName> {
return Object.assign(
(args: ActivityLoaderArgs<ActivityName>) => loaderFn(args),
options,
);
return (args: ActivityLoaderArgs<ActivityName>) => loaderFn(args);
}
46 changes: 0 additions & 46 deletions integrations/react/src/future/stackflow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ export type StackflowOutput = {
stepActions: StepActions<ActivityBaseParams>;
};

const DEFAULT_LOADER_CACHE_MAX_AGE = 1000 * 30;

export function stackflow<
T extends ActivityDefinition<RegisteredActivityName>,
R extends {
Expand All @@ -60,17 +58,7 @@ export function stackflow<
>;
},
>(input: StackflowInput<T, R>): StackflowOutput {
const loaderDataCacheMap = new Map<string, { params: {}; data: unknown }[]>();
const loadData = (activityName: string, activityParams: {}) => {
const cache = loaderDataCacheMap.get(activityName);
const cacheEntry = cache?.find((entry) =>
isEqual(entry.params, activityParams),
);

if (cacheEntry) {
return cacheEntry.data;
}

const activityConfig = input.config.activities.find(
(activity) => activity.name === activityName,
);
Expand All @@ -83,40 +71,6 @@ export function stackflow<
params: activityParams,
config: input.config,
});
const newCacheEntry = {
params: activityParams,
data: loaderData,
};

if (cache) {
cache.push(newCacheEntry);
} else {
loaderDataCacheMap.set(activityName, [newCacheEntry]);
}

const clearCache = () => {
const cache = loaderDataCacheMap.get(activityName);

if (!cache) return;

loaderDataCacheMap.set(
activityName,
cache.filter((entry) => entry !== newCacheEntry),
);
};
const clearCacheAfterMaxAge = () => {
setTimeout(
clearCache,
activityConfig.loader?.loaderCacheMaxAge ??
DEFAULT_LOADER_CACHE_MAX_AGE,
);
};

Promise.resolve(loaderData).then(clearCacheAfterMaxAge, (error) => {
clearCache();

throw error;
});

return loaderData;
};
Expand Down
Loading