This repository was archived by the owner on Dec 21, 2025. It is now read-only.
Fixes #365: Don't pop an empty queue #376
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x42005e1f
reviewed
Oct 17, 2025
| def _kernel_wake(self, ntasks=1): | ||
| tasks = [] | ||
| while ntasks > 0: | ||
| while ntasks > 0 and len(self._queue) > 0: |
There was a problem hiding this comment.
I think that truth testing will also be sufficient:
while self._queue and ntasks > 0:
...This is the same as checking the length for non-zero (it cannot be less than zero anyway), but it takes fewer bytecode instructions. And this pattern is also present in the existing code base.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix IndexError from being raised inside the kernel by turning SchedFIFO wake into a no-op if there are no tasks waiting.
See discussion on #365.