Skip to content

fix: display learning module level regardless of the challenge level #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: display learning module level regardless of the challenge level #1295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/cards/LearningModule.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ export function LearningModuleCard({ data }: { data: LearningModule }): JSX.Elem
})

const level = useMemo(() => {
const value = data?.level || challenge?.level;
const value = data?.level;
return t((value === 0 || value === 1) ? "course.challenge.level-0" : "course.challenge.level-2");
}, [challenge?.level]);
}, [data?.level]);

const courses = data?.courses.map(course => ({ name: course.name, slug: course.slug }))

Expand All @@ -38,7 +38,7 @@ export function LearningModuleCard({ data }: { data: LearningModule }): JSX.Elem
<span className="uppercase font-semibold">{t("communities.card.module")}</span>
</div>
<div className="gap-2 flex items-center">
{challenge?.level && <Tag className="uppercase">{level}</Tag>}
{data?.level && <Tag className="uppercase">{level}</Tag>}
<DurationBadge value={data.duration} type="bordered" />
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/sections/courses/_partials/Duration.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ interface DurationProps {
*/
export default function Duration({ text, value }: DurationProps): ReactElement {
const colors = useSelector((state) => state.ui.colors);
const duration = value ? DateManager.humanize(value, "en") : 0;
const duration = value ? DateManager.humanize(value, "en") : "";

return (
<div>
Expand Down