-
Notifications
You must be signed in to change notification settings - Fork 7
test: add test for submission popup header #1296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mhenriette
wants to merge
3
commits into
dev
Choose a base branch
from
test/popups-submission
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
29 changes: 29 additions & 0 deletions
29
__tests__/components/popups/submission/_partials/Header.test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,29 @@ | ||||||
import SubmissionPopup from "@/components/popups/submission/_partials/Header"; | ||||||
import "@testing-library/jest-dom"; | ||||||
import { render, screen, fireEvent } from "@testing-library/react"; | ||||||
|
||||||
describe("SubmissionPopup", () => { | ||||||
const mockOnClose = jest.fn(); | ||||||
|
||||||
|
||||||
it("renders the component with correct text", () => { | ||||||
render(<SubmissionPopup onClose={mockOnClose} />); | ||||||
expect(screen.getByText("communities.submission")).toBeInTheDocument(); | ||||||
}); | ||||||
|
||||||
it("calls onClose when clicking the arrow icon", () => { | ||||||
render(<SubmissionPopup onClose={mockOnClose} />); | ||||||
|
||||||
const arrowButton = screen.getByText("communities.submission").parentElement; | ||||||
fireEvent.click(arrowButton!); | ||||||
expect(mockOnClose).toHaveBeenCalled(); | ||||||
}); | ||||||
|
||||||
it("calls onClose when clicking the close button", () => { | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
render(<SubmissionPopup onClose={mockOnClose} />); | ||||||
const closeButton = screen.getByRole("button"); | ||||||
fireEvent.click(closeButton); | ||||||
expect(mockOnClose).toHaveBeenCalled(); | ||||||
}); | ||||||
|
||||||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import SubmissionPopup from "@/components/popups/submission"; | ||
import { renderWithRedux } from "@__mocks__/renderWithRedux"; | ||
import "@testing-library/jest-dom"; | ||
import { fireEvent, screen } from "@testing-library/react"; | ||
serapieTuyishime marked this conversation as resolved.
Show resolved
Hide resolved
|
||
describe("SubmissionPopup", () => { | ||
|
||
const mockOnClose = jest.fn(); | ||
|
||
it("renders the popup when show is true", () => { | ||
renderWithRedux(<SubmissionPopup show={true} onClose={mockOnClose} submissionId="123" />); | ||
expect(screen.getByTestId("overlay")).toBeInTheDocument(); | ||
expect(screen.getByText("communities.submission")).toBeInTheDocument(); | ||
expect(screen.getByTestId("viewId")).toBeInTheDocument(); | ||
}); | ||
|
||
it("does not render the popup when show is false", () => { | ||
renderWithRedux(<SubmissionPopup show={false} onClose={mockOnClose} submissionId="123" />); | ||
expect(screen.queryByTestId("overlay")).not.toBeInTheDocument(); | ||
}); | ||
|
||
it("calls onClose when the close button is clicked", () => { | ||
renderWithRedux(<SubmissionPopup show={true} onClose={mockOnClose} submissionId="123" />); | ||
const buttonElement = screen.getByText("communities.submission").parentElement; | ||
fireEvent.click(buttonElement!); | ||
expect(mockOnClose).toHaveBeenCalled(); | ||
}); | ||
serapieTuyishime marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.