-
Notifications
You must be signed in to change notification settings - Fork 7
docs: add test prefix #1314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
docs: add test prefix #1314
Conversation
📝 Walkthrough📝 WalkthroughWalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Contributor
participant Repository
participant CI
Contributor->>Repository: Create feature branch (e.g., test/add-unit-tests)
Contributor->>Repository: Make commits following Conventional Commits
Contributor->>Repository: Create Pull Request after first commit
Repository->>CI: Run CI checks
CI-->>Repository: CI checks pass
Repository->>Contributor: PR ready for review
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🪛 GitleaksREADME.md90-91: Discovered a potential Discord client secret, risking compromised Discord bot integrations and data leaks. (discord-client-secret) 79-79: Uncovered a GCP API key, which could lead to unauthorized access to Google Cloud services and data breaches. (gcp-api-key) Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for staging-dacade ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
CONTRIBUTING.md (1)
23-23
: LGTM! Consider enhancing the test prefix descriptionThe addition of the
test
prefix for testing branches is a good improvement to the branch naming convention. The example provided is clear and follows the established pattern.Consider adding a brief description of when to use the
test
prefix, similar to how other prefixes are self-explanatory. For example:-Feature branches should have one of the following prefixes: fix (bug fix), ft (feature), ht (hotfix), chore, doc (documentation), or test(testing) followed by a forward slash and a descriptive name. +Feature branches should have one of the following prefixes: fix (bug fix), ft (feature), ht (hotfix), chore, doc (documentation), or test (for test additions/improvements) followed by a forward slash and a descriptive name.Also applies to: 32-32
Submit a pull request
Replace any ":question:" below with information about your pull request.
Pull Request Details
Provide details about your pull request and what it adds, fixes, or changes.
❓
Breaking Changes
Describe what features are broken by this pull request and why, if any.
❓
Issues Fixed
Enter the issue numbers resolved by this pull request below, if any.
Other Relevant Information
Provide any other important details below.