Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UPGRADE.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## 4.0.9
- [BUGFIX] fixed document deletion [see more](https://github.com/dachcom-digital/pimcore-dynamic-search/pull/108)
- [IMPROVEMENT] allow `data_transformer` to accept `null` values and handle null resource field transformers
## 4.0.8
- [IMPROVEMENT] `dynamic_search.element_listener_options.allowed_document_types` added, read more about it [here](./docs/01_DispatchWorkflow.md#listener)
## 4.0.7
Expand Down
4 changes: 2 additions & 2 deletions src/Document/Definition/DocumentDefinition.php
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public function addOptionFieldDefinition(array $definition): static
$resolver = new OptionsResolver();
$resolver->setRequired(['name', 'data_transformer']);
$resolver->setAllowedTypes('name', ['string']);
$resolver->setAllowedTypes('data_transformer', ['array']);
$resolver->setAllowedTypes('data_transformer', ['array', 'null']);

try {
$options = $resolver->resolve($definition);
Expand Down Expand Up @@ -100,7 +100,7 @@ public function addSimpleDocumentFieldDefinition(array $definition): static
$resolver->setRequired(['name', 'index_transformer', 'data_transformer']);
$resolver->setAllowedTypes('name', ['string']);
$resolver->setAllowedTypes('index_transformer', ['array']);
$resolver->setAllowedTypes('data_transformer', ['array']);
$resolver->setAllowedTypes('data_transformer', ['array', 'null']);

try {
$options = $resolver->resolve($definition);
Expand Down
8 changes: 7 additions & 1 deletion src/Generator/IndexDocumentGenerator.php
Original file line number Diff line number Diff line change
Expand Up @@ -180,9 +180,15 @@ protected function processDocumentIndexTransformerField(
/**
* @throws \Exception
*/
protected function dispatchResourceFieldTransformer(array $options, string $dispatchTransformerName, ResourceContainerInterface $resourceContainer): mixed
protected function dispatchResourceFieldTransformer(?array $options, string $dispatchTransformerName, ResourceContainerInterface $resourceContainer): mixed
{
$fieldTransformerName = $options['type'];

// it's not a source field
if ($fieldTransformerName === null) {
return null;
}

$fieldTransformerConfiguration = $options['configuration'];

$fieldTransformer = $this->transformerManager->getResourceFieldTransformer($dispatchTransformerName, $fieldTransformerName, $fieldTransformerConfiguration);
Expand Down