fix: support absolute paths in include directive #908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #906 When using absolute paths in the include directive, the path was incorrectly joined with the entry directory, resulting in paths like '/etc/dae/etc/dae/sub.dae' instead of '/etc/dae/sub.dae'. This commit checks if the include path is absolute before joining it with the entry directory, allowing absolute paths to work correctly.
Contributor
|
Please add an example of absolute path in https://github.com/daeuniverse/dae/blob/main/example.dae#L136 |
Contributor
Author
As you wish, I've added examples for absolute path. Just to clarify, this PR only fixes absolute paths in the include { ... } directive (config merger). It doesn’t change the subscription file://... handling. |
MarksonHon
added
documentation
![dae-prow[bot]](https://avatars.githubusercontent.com/in/345419?s=60&v=4){kind=small}
MarksonHon
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #906
Check if the include path is absolute before joining it with the entry directory.