Merged
Conversation
aluzzardi
force-pushed
the
log-revamp
branch
5 times, most recently
from
6326c49 to
1abc0be
Compare
- Notes are added *after* the commit, instead of being applied to the previous commit. - Cleaner commit messages containing only the explaination. The "operation" part (e.g. write file foo) is a note. - Cleaned up command execution notes - More concise `cu log` output Signed-off-by: Andrea Luzzardi <al@dagger.io>
cwlbraa
approved these changes
Jul 3, 2025
Contributor
cwlbraa
left a comment
cwlbraa
left a comment
There was a problem hiding this comment.
lgtm, other comment is non blocking but worth thinking on
| assert.Contains(t, stagingLog, "Write config.json") | ||
| assert.Contains(t, stagingLog, "Create env") | ||
| assert.Contains(t, devLog, "Dev config") | ||
| assert.Contains(t, stagingLog, "Staging config") |
Contributor
There was a problem hiding this comment.
Maybe we wanna get a bit stricter in the tests about not having extraneous audit lines?
gsnaiper
pushed a commit
to gsnaiper/container-use
that referenced
this pull request
Nov 19, 2025
- Notes are added *after* the commit, instead of being applied to the previous commit. - Cleaner commit messages containing only the explaination. The "operation" part (e.g. write file foo) is a note. - Cleaned up command execution notes - More concise `cu log` output Signed-off-by: Andrea Luzzardi <al@dagger.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cu logoutput