mrepo: Remove temporary reposync config files before raising exceptions#73
Open
clayne wants to merge 1 commit intodagwieers:masterfrom
Open
mrepo: Remove temporary reposync config files before raising exceptions#73clayne wants to merge 1 commit intodagwieers:masterfrom
clayne wants to merge 1 commit intodagwieers:masterfrom
Conversation
If a single file/fetch fails during a reposync, mrepo will raise an exception over it (and continue) but will not cleanup the temporary config. Results in this: $ ls -la /tmp/tmp* | tail -rw------- 1 root root 133 Jun 29 23:15 /tmp/tmpzCRrbK -rw------- 1 root root 133 Jun 26 22:45 /tmp/tmpzCdtxq -rw------- 1 root root 133 Jul 6 04:15 /tmp/tmpzJ2rdp -rw------- 1 root root 133 Jul 2 16:30 /tmp/tmpzKc_s5 -rw------- 1 root root 133 Jun 27 14:15 /tmp/tmpzW4E_h -rw------- 1 root root 133 Jul 6 15:30 /tmp/tmpzhzBuJ -rw------- 1 root root 133 Jun 27 07:45 /tmp/tmpziEzGo -rw------- 1 root root 133 Jun 26 03:30 /tmp/tmpzkp3Ym -rw------- 1 root root 133 Jun 26 19:30 /tmp/tmpztKB57 -rw------- 1 root root 133 Jul 5 12:15 /tmp/tmpztbK9i $ ls -la /tmp/tmp* | wc -l 1039 $ sudo cat /tmp/tmpztbK9i [EnterpriseLinux5-x86_64-percona] name=EnterpriseLinux5-x86_64-percona baseurl=http://repo.percona.com/centos/5/os/x86_64/ enabled=1
Author
|
Any chance this can be merged? It's been sitting here for almost 2 years. We've already implemented the change in our own fork and there are zero issues. This fixes an actual bug in the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a single file/fetch fails during a reposync, mrepo will raise an
exception over it (and continue) but will not cleanup the temporary
config.
Results in this: