-
Notifications
You must be signed in to change notification settings - Fork 3
Convert tests to @testitem format with TestItemRunner.jl #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: dahong67 <9384655+dahong67@users.noreply.github.com>
Co-authored-by: dahong67 <9384655+dahong67@users.noreply.github.com>
Co-authored-by: dahong67 <9384655+dahong67@users.noreply.github.com>
Co-authored-by: dahong67 <9384655+dahong67@users.noreply.github.com>
Co-authored-by: dahong67 <9384655+dahong67@users.noreply.github.com>
Co-authored-by: dahong67 <9384655+dahong67@users.noreply.github.com>
Co-authored-by: dahong67 <9384655+dahong67@users.noreply.github.com>
dahong67
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot please revise based on the following notes:
- only TestItemRunner needs to be loaded at the top-level of
runtests.jl - many of the added
usingstatements are unnecessary since@testitemloads CacheVariables already - rather than adding code to create cache files in load tests, these tests should simply be merged with the save testitem above it
- the complicated begin...end block case seems to be failing because the variables defined by
@cachein@test_logsdon't seem to be escaping out, this can be solved by simply dropping the log check
Co-authored-by: dahong67 <9384655+dahong67@users.noreply.github.com>
Done in 9d7b640. Changes made:
All 65 tests now pass. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: dahong67 <9384655+dahong67@users.noreply.github.com>
Done in d75c6c0. All tests now use Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot good progress, please work on two more things:
|
Co-authored-by: dahong67 <9384655+dahong67@users.noreply.github.com>
Done in 0c77f04. Changes:
All 65 tests pass with no leftover directories. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 40 40
=========================================
Hits 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DataFrames should not be loaded outside the module
dahong67
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. As long as tests all pass, ready to merge!
Convert tests to @testitem format with TestItemRunner.jl
Changes Made
@testsetblocks to@testitemblocks inruntests.jl@run_package_tests@testitemusesmktempdirwith automatic cleanup for temporary test directories@test_logswrappers from complicated test to allow proper variable assignmentmktempdir(@__DIR__; prefix="temp_")ensures all test directories are automatically cleaned up by JuliaKey Improvements from Latest Changes
using BSON, Datesstatements from testitems that don't directly use these packagesmktempdirinside the module) instead of defining a function that gets called from outsideAll 65 tests pass successfully.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.