Set compat for BSON and drop bson_mod #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems that the issue this kwarg was trying to address is no longer relevant, so going to remove it. Also, unclear if it was really working to address that issue anyway. Anyway, can always be added back later.
Owner
Author
|
This screenshot shows the error arising when using BSON v0.3.6: 
Setting the module doesn't seem to fully address things either 
However, interestingly on BSON v0.3.7, the errors seem to go away! 
|
Owner
Author
|
Possibly relevant: JuliaIO/BSON.jl#120 Since that seems to be the main change in v0.3.7: https://github.com/JuliaIO/BSON.jl/releases/tag/v0.3.7 |
May need to hold expressions, symbols, etc.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 57 57
=========================================
Hits 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
Author
|
Looks good, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that the issue this kwarg was trying to address is no longer relevant, so am going to remove it. Also, unclear if it was really working to address that issue anyway. Anyway, can always be added back later.