Fix Glyph issues and remove CPP network patch#478
Fix Glyph issues and remove CPP network patch#478julien-duponchelle wants to merge 1 commit intodaijro:mainfrom
Conversation
This PR fix the broken Accept-Encoding and clean the override code to use only firefox settings to set: * User-Agent * Accept-Encoding * Accept-Language This allow to drop the network-patches reducing the maintenance cost. User-Agent and Accept-Language was already no longer used in the patch as mentionned in the browserforge.yml For the Accept-Encoding we are using the firefox settings network.http.accept-encoding.secure. It's important to apply it only for HTTPS because the value for HTTP is different. The fingerprint provided by BrowserForge match the HTTPS settings. I cleaned camoucfg.jvv and properties.json but I'm not 100% sure it's what we need to do.
|
Thanks for opening. I'm going to have someone else make sure that the useragent mask isn't being used in an upcoming fingerprint update. |
|
I have a local mac build (FF146) with this patch. It works great except my navigator.userAgent is missing, and cannot be overridden by python setting. I have to include the I believe we don't need the entire network-patches tho, only the nsHttpHandler -> navigator.userAgent part. |
|
@decewei how to build FF146 on macOS |
Yeah I was planning to post a PR to add to build guide. May take me a few days tho. PS took me a long time to figure out plus my machine is not so powerful that made it worse. |
|
Ok thx u very much i will waiting it i love u |
@KittisakPh I didn't actuall find time to post a proper PR. It still needs some clean up. Here is the branch with a commit that works: decewei@3e8f2a0 There are some redundant things in it that you can ignore. |
This PR fix the broken Accept-Encoding and clean the override code to use only firefox settings to set:
This allow to drop the network-patches reducing the maintenance cost.
User-Agent and Accept-Language was already no longer used in the patch as mentionned in the browserforge.yml
For the Accept-Encoding we are using the firefox settings network.http.accept-encoding.secure. It's important to apply it only for HTTPS because the value for HTTP is different. The fingerprint provided by BrowserForge match the HTTPS settings.
I cleaned camoucfg.jvv and properties.json but I'm not 100% sure it's what we need to do.
I tested the change with this code:
And I got :