Include cstdin in scintilla for GCC15 compatibility #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Normally I leave any of the Scintilla stuff completely unmodified but willing to merge in these minor changes knowing that the upstream Scintilla project will include these soon. I would also make sure the Scintilla bug report knows about the other place you had to include the header for the qt specific files. |
Owner
|
Ah looks like they did already. https://sourceforge.net/p/scintilla/code/ci/c7ffad21b23dfad4e8e9f36bb587acc2f6e84fee/ |
matthewyang204
pushed a commit
to matthewyang204/NotepadNext
that referenced
this pull request
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to add cstdin in 3 places to make it compile successfully with the upcoming gcc15, because cstdin is not automatically included anymore. Reference: https://gcc.gnu.org/gcc-15/porting_to.html and https://sourceforge.net/p/scintilla/bugs/2458/
I am no expert, so I don't know what style guidelines are custom for the placement of those includes. If necessary, I can adapt the commits. Let me know what you think, thanks
The corresponding bug report is #669