Update-deps (git submodules) #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Just curious, does this fix any particular issue you are having? Or is this just to update the submodules just for the sake of updating? |
Contributor
Author
No, I think it's good practice to update dependencies when they are released new "stable" versions. |
Owner
|
Looking at the actual changes there is really no significant code changes. Maybe the uchardet library but that library is barely even used. The ADS library has not released another stable version. Even with that the last 'stable' version it was on had issues. I normally dont update submodules unless there's a good reason but I guess I see no harm in it. |
matthewyang204
pushed a commit
to matthewyang204/NotepadNext
that referenced
this pull request
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subj