Skip to content

Conversation

@kolcz
Copy link
Contributor

@kolcz kolcz commented Oct 3, 2025

Description

This PR is a part of modification approved to implement in #825 issue thread. In this PR double clicking on search result caret is placed at the end of selection.

Changes Made

  • In ScintillaNext goToRange function during selecting text the anchor and caret position are changed

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change
  • Documentation update

Testing - on Windows 11 and Debian 12 bookworm

  • Text return by ScintillaEdit::getSelText function stays the same
  • Text selected by item activation or find, replace, performLastSearch visualy stays the same

@kolcz
Copy link
Contributor Author

kolcz commented Oct 3, 2025

Hi @dail8859,
could you take a look if I didn't miss anything? I have tested changes as it's stated in description, but maybe you see any other place that modifications would mess up application. Thanks in advance. :)

@kolcz
Copy link
Contributor Author

kolcz commented Oct 4, 2025

@dail8859 please also check Windows runner. PR #874 also didn't pass only Windows build tests.

@dail8859 dail8859 force-pushed the move_caret_to_end_for_selection_in_search_results branch from f197c0a to 4ed6ca0 Compare October 4, 2025 20:42
@dail8859
Copy link
Owner

dail8859 commented Oct 4, 2025

I rebased this on top of the latest master which should allow the Windows runners to complete.

Once that passes I'll merge this in. Agree that this proposed behavior is the desired affect.

@dail8859
Copy link
Owner

dail8859 commented Oct 4, 2025

Silly me, I didnt merge in my pull request to fix the Windows builds yet 🙃

@dail8859 dail8859 merged commit b53f10d into dail8859:master Oct 4, 2025
12 checks passed
@dail8859
Copy link
Owner

dail8859 commented Oct 4, 2025

Thanks for your PR!

@kolcz
Copy link
Contributor Author

kolcz commented Oct 5, 2025

You're welcome. :)

@kolcz kolcz deleted the move_caret_to_end_for_selection_in_search_results branch October 5, 2025 17:24
matthewyang204 pushed a commit to matthewyang204/NotepadNext that referenced this pull request Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants