Rename the Find in Files function to Replace in Files and then build Replace in Files#880
Closed
matthewyang204 wants to merge 33 commits intodail8859:masterfrom
Closed
Rename the Find in Files function to Replace in Files and then build Replace in Files#880matthewyang204 wants to merge 33 commits intodail8859:masterfrom
matthewyang204 wants to merge 33 commits intodail8859:masterfrom
Conversation
Still learning Qt C++
Contributor
Author
|
Build succeeded on Qt 6 on Ubuntu 24.04 LTS & Qt 5 on Debian 13 Trixie |
Contributor
Author
|
Also, to note, I also get some occasional UI glitches on my Debian tower under GNOME |
Should fix problems with squeezing
matthewyang204
force-pushed
the
master
branch
from
cc08847 to
7cc9fb2
Compare
Contributor
Author
|
Alright, the UI is less screwed up after I added those two commits to make it so the window can't be shrunk to zero size. |
Contributor
Author
|
Also, to note, this only works on ASCII & UTF-8 files. However, it is reliable enough and besides, this editor doesn't even have support for other encodings yet anyways |
matthewyang204
force-pushed
the
master
branch
from
9340b1b to
7cc9fb2
Compare
Contributor
Author
|
@dail8859 Can you please take a look at this PR? It's been a long time. |
matthewyang204
force-pushed
the
master
branch
from
70f0a0e to
448e635
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Please check that you like it, and then make any changes you want. Otherwise, feel free to merge. Also, given the number of commits, you may not want to squash the entire thing into one patch