feat: add JSON upload feature for log data override #5227
Closed
+487
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove 404 getServerSideProps from log page to allow access - Add LogDataOverrideContext to store uploaded JSON data in memory - Modify useLog hook to prioritize override data over API data - Add file upload UI to CardWelcome with validation - Implement comprehensive JSON validation for LogData structure - File data is stored only in memory, not persisted Users can now upload custom log data via JSON file on the welcome screen. The uploaded data is validated against the LogData schema and replaces API data for the session.
idoshamun
requested review from
AmarTrebinjac,
capJavert,
omBratteng and
rebelchris
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
- Import UploadIcon from direct path since it's not exported in icons index - Remove console.error statements to pass linting with max-warnings 0 - Apply prettier formatting to all modified files
- Return default values when context is not available during SSR - File upload only happens on client, so null override data is safe - Fixes prerendering error for /log page
- Add overrideData tracking to force card remount when uploaded data replaces API data - Use compound key (currentCard + data source) for AnimatePresence - Ensures all cards refresh with new data immediately after upload
Member
Author
|
No need to review. This is for internal testing |
- Stop click event propagation on upload button - Prevents tap navigation when clicking upload button - User can now click upload button without navigating to next card
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now upload custom log data via JSON file on the welcome screen.
The uploaded data is validated against the LogData schema and replaces
API data for the session.
Preview domain
https://claude-add-json-upload-feature-v.preview.app.daily.dev