-
Notifications
You must be signed in to change notification settings - Fork 290
refactor: improve profile completion card with dismiss and sections list #5254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AmarTrebinjac
wants to merge
12
commits into
main
Choose a base branch
from
profile-card-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+316
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new ProfileCompletionCard component that encourages users to complete their profile by showing their progress and the next incomplete section. The card displays in the first feed slot and takes priority over the brief card, using the existing ProfileCompletion logic and displaying a cabbage-themed design. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <[email protected]>
- Use softer, less saturated brand purple colors for border and button - Replace generic text with benefit-focused copy for each profile section - Add section-specific CTAs that explain the value of completing each field 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <[email protected]>
…ing sections - Replaced custom brand color scheme with default card styling (neutral border and background) - Added dismiss button to hide the card with action tracking - Changed card body to display all incomplete profile sections as a bullet list - Added ProfileCompletionCard action type for dismissal tracking - Updated useProfileCompletionIndicator to respect dismissal state 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <[email protected]>
When the user dismisses the profile completion card, the brief card should not appear as a replacement. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <[email protected]>
Create useProfileCompletionCard hook with useConditionalFeature to control card visibility via GrowthBook. Card only shows when feature is enabled, user is on My Feed, profile is incomplete, and card hasn't been dismissed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
…card - Reorder hooks so profile card is evaluated before brief card - Brief card feature only evaluates when profile card definitively won't show - Add isLoading state to prevent brief card flash while profile card loads - Use hasNotDismissed pattern (requires isActionsFetched) to match brief card This ensures users are only exposed to one experiment at a time, preventing skewed A/B test statistics. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add impression, click, and dismiss event tracking following the same pattern as marketing CTAs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
LogEvent.Dismiss doesn't exist - use Click with target_id to differentiate between CTA click and dismiss actions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ProfileCompletionCardaction type for dismissal trackinguseProfileCompletionIndicatorto respect dismissal stateCard will now show all remaining profile sections (Profile image, Headline, Experience level, Work experience, Education) and allow users to dismiss it permanently.
Events
No new tracking events, using existing
completeActionmutation with new action type.Preview domain
https://profile-card-v2.preview.app.daily.dev